weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.87k stars 714 forks source link

probe: avoid reporting the container ID as its hostname #3746

Open bboreham opened 4 years ago

bboreham commented 4 years ago

If hostname isn't set on a container it defaults to a random hex number, which we don't want to show in the UI.

bboreham commented 4 years ago

Example: you can see that the hostname of the container is the first 12 characters of the container ID.

image

bboreham commented 4 years ago

However, with this PR the second container disappears from the "containers by DNS name" view. I'm not sure that is an improvement.