search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.85k stars 709 forks source link

fix (multitenant collector): Use consistent report timestamp #3773

Closed bboreham closed 4 years ago

bboreham commented 4 years ago

Previously the code called time.Now() in two different places so the timestamps didn't match. Now we use the timestamp of the report itself.

Add the collector's local time to the report if it didn't have one.

bboreham commented 4 years ago

It turns out this change is problematic in the case that the probe's idea of the time is different to the app's: the newest reports may fall outside of the "display window" and hence nothing appears in view.