search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.85k stars 709 forks source link

Multitenant: merge incoming reports in collector #3780

Closed bboreham closed 4 years ago

bboreham commented 4 years ago

This means we store fewer, bigger, reports, which reduces cost of storage and time to render when data is viewed.

fbarl commented 4 years ago

Conceptually LGTM! I only added a few minor comments concerning the config robustness.

I just looked at the code though (didn't go as far as trying to test) - how well do you think the current unit tests cover the logic modified here?

bboreham commented 4 years ago

The current unit tests don't cover any of the DynamoDB/S3 code. I think if I was going to add tests I'd do it as integration tests, running mock DynamoDB and S3 containers.