Stop pipe operations after EOF

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes

https://www.weave.works/oss/scope/

Apache License 2.0

5.86k stars 714 forks source link

Stop pipe operations after EOF #3784

Closed bboreham closed 4 years ago

bboreham commented 4 years ago

Fixes #3684

Move the check for IsExpectedWSCloseError() inside CopyToWebsocket() and only do the check on the websocket side.

Previously we were treating EOF on the non-websocket side of the conversation as no-error, meaning that operations like Kubernetes Describe would retry endlessly when finished.