Transition weave-scope Helm chart into this repository?

dholbach commented 4 years ago

https://github.com/helm/charts/tree/master/stable/weave-scope will be retired Aug 18 and it might make sense to transition the chart over into this repository to keep it all in one place and potentially attract contributors here as well?

kured has almost completed the process in https://github.com/weaveworks/kured/issues/140 and

kured was very lucky to have @ckotzbauer and @davidkarlsen who helped out with the process.

Maybe it'd be possible to invite some of the folks in https://github.com/helm/charts/commits/master/stable/weave-scope and https://github.com/helm/charts/issues?q=weave-scope+is%3Aopen+ to help out?

dholbach commented 4 years ago

Meeting is happening next week 28th July: https://docs.google.com/document/d/103_60TuEkfkhz_h2krrPJH8QOx-vRnPpbcCZqrddE1s/edit# - please join to discuss it there.

dholbach commented 4 years ago

I reached out to the authors who contributed to the chart and we have a couple of offers of help.

The way we set this up with kured (if we want to follow the same model) is

two Github Actions that are triggered whenever a release is tagged
in https://github.com/weaveworks/kured/pull/150 we copied the chart as is in the first commit, then applied a number of changes to make the chart more compliant with current standards, resolved a couple of inconsistencies, then added the GH actions
if memory serves, we only needed to set up an empty gh-pages branch and enable Github pages - that was all
it needed a couple more commits to get it all working fine, but it wasn't too much work

Does anyone want to set up an initial PR for this?

Scope maintainers (@qiell @bboreham @fbarl @satyamz): Any opinions on how to move forward?

dholbach commented 4 years ago

https://github.com/helm/charts/issues/21103 will need an update too.

davidkarlsen commented 4 years ago

I've updated the issue in helm-charts.

scottrigby commented 4 years ago

Thanks for this!

Could you use help pulling in the chart commit history or setting up the Helm GH Actions? See this git repo for an up to date reference https://github.com/helm/charts-repo-actions-demo

I mentioned chart commit history only because this has proven useful elsewhere. It may even be worth bringing back the chart history for kured. For an example on doing this retroactively, see this issue https://github.com/goharbor/harbor-helm/issues/48 I also don't mind helping with a PR, it would just take a little coordination.

One more thought. An idiomatic way to manage an org's charts is a separate git repo holding the source code for multiple charts. The benefit here is simplifying setup for chart CI (testing/releasing) in only one place whenever updates are needed. I'd be happy to setup an example of this so you can see it using the above history splicing on all the weave charts, if that would be helpful (if so, please ping in k8s slack #charts channel in case I miss a reply here).

dholbach commented 4 years ago

Thanks @scottrigby for adding more detail to the discussion - we talked about this in the kured meetings and decided we'd like to have the source available in the same repository to focus everyone's attention on the same code. Not sure how the Scope maintainers feel about this.

Losing commit history in kured is a fair point. We could file an issue for that in kured and see if we can easily bring it back.

Thanks also for your offer of help!

scottrigby commented 4 years ago

@dholbach I can see that too - keeping chart with app source is also legit 👍 Re help, any time 😄

dholbach commented 4 years ago

@cpanato @daixiang0 @ckotzbauer and @davidkarlsen all offered help too.

Does anyone want to take the lead and we discuss in the Scope meeting (28th July) ... or any time on Slack?

daixiang0 commented 4 years ago

@dholbach hi, i would to like to do it, let us talk at Slack.

ckotzbauer commented 4 years ago

@dholbach I can join the meeting on 28th.

scottrigby commented 4 years ago

Hey gang, just following up to see if anything new came out of the scope meeting?

dholbach commented 4 years ago

So the helm chart upstream is being retired today. Does anyone have time today (or soon) to take a look at this?

scottrigby commented 4 years ago

@dholbach To be clear, the stable repo will still be operational until Nov 13, just de-listed soon from Helm Hub (and Artifact Hub. See https://github.com/helm/helm/pull/8626). That means new users browsing the Hubs (or with helm search hub command) won't see the chart listed until it's moved to a new helm repo and registered with the hubs. Buys a little more time, but still good to prioritize 😸

dholbach commented 3 years ago

This has happened now: https://github.com/helm/charts/pull/24414