search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.84k stars 708 forks source link

Only mount plugins directory if it exists #3825

Closed bboreham closed 3 years ago

bboreham commented 3 years ago

This gets over a problem with Docker for Mac where /var/run is read-only. Now, anyone wishing to use Scope plugins will have to ensure that directory (where the sockets used to communicate between Scope and plugins live) exists.

I'm not clear whether it is ever possible under Docker for Mac to create the /var/run/scope/plugins directory the code is looking for, or whether it will be necessary to parameterise the code.

Also fix the Mac probe launch command - paren in wrong place meant it was running the app and not getting any extra args