search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.84k stars 708 forks source link

Remove obsolete dependency github.com/fatih/hclfmt #3834

Closed Kielek closed 3 years ago

Kielek commented 3 years ago

github.com/fatih/hclfmt was archived. Technically there is a possibility to fork (or used another forked version) to executle hclfmt.

But it leads to another issues - problems with importing https://github.com/hashicorp/hcl/hcl/printers. HCL was released in version 2 so that the file structure was changes. I do not see any way to install it in changed Makefile. Go installs does not support pining to given tags so that always the newest version is installed.

For now, the impact on build process should be minimal. it is used only in ./tools/lint/lint() method. I was able to execute it locally without executing hclfmt.

Kielek commented 3 years ago

Should solve #3832

Kielek commented 3 years ago

@bboreham, could you please check?

bboreham commented 3 years ago

Sorry, been doing other things. Please feel free to ping me again in a few days if I still haven't looked.

Kielek commented 3 years ago

@bboreham?