search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.84k stars 708 forks source link

Update alpine base image to 3.13 #3838

Closed gaby closed 3 years ago

gaby commented 3 years ago

Update alpine 3.11 to latest patch version.

It would make more sense at this point to update to 3.13, let me know if you want make to make the change.

Change log for 3.11.8: https://alpinelinux.org/posts/Alpine-3.10.6-3.11.8-3.12.4-released.html

bboreham commented 3 years ago

Happy to make a bigger jump.

I don't believe Alpine flaws are exploitable in a normal Scope situation, but I recognize that folks run tools which highlight them.

gaby commented 3 years ago

@bboreham Great, changes have been made. Alpine now points to 3.13

kingdonb commented 3 years ago

Looks like the build fails now, you might try adding libpcap-dev?

Also, the old Dockerfile was specific about MAJOR.MINOR.Patch, let's keep that property... would you change the form of the FROM line from 3.13 back to 3.13.2 that mentions the more specific latest release available at this time?

gaby commented 3 years ago

Test still failing, I will take a look again tonight. The integration test for alpine 3.11.8 also failed, so it must be something else missing.

See https://github.com/google/gopacket/issues/734

gaby commented 3 years ago

@bboreham @kingdonb I tried debugging this, but I can't figure out why it fails. PR #3834 is also failing with the same error.

bboreham commented 3 years ago

The integration tests basically don't run at all for 3rd-party forks, due to mining. #2192

I have pushed your branch as 1st-party, so now the tests will re-run and hopefully succeed.

I apoologise the error message is very hard to understand; it would be better to fail the job straight off if it doesn't have secrets.

Kielek commented 3 years ago

@bboreham, do you have any plans to official 1.13.2 release with the latest changes? Including new alpine?