search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.84k stars 708 forks source link

allow to read password from file #3851

Closed Kielek closed 3 years ago

Kielek commented 3 years ago

it enables option to utilize docker swarm secret storage for password instead of env variables or app switches

Kielek commented 3 years ago

@bboreham, if you are fine with these changes, it will be great to have new offical release. 1.13.3?

Kielek commented 3 years ago

Bigger point though: what happens if the file is not readable? Looks to me like the system will then be open to all callers, which is probably not what the administrator would expect if they configured a password file.

You are right. I have change log to Fatal, it should close the process and I think, it is expected solution.

Kielek commented 3 years ago

@bboreham, any chance to move forward with this PR (and prepare next official release)?

Kielek commented 3 years ago

@bboreham, is there any chance that you check this PR?