weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.84k stars 708 forks source link

Improve behaviour of the 'cordon' button #3862

Open bboreham opened 3 years ago

bboreham commented 3 years ago

After #3822 the merging of active controls is still a bit off - when you press 'cordon' it doesn't update for a few seconds, then you get both cordon and uncordon buttons, then a bit later the cordon button goes away.

I believe the slow reaction is because the display is updated on a 5-second timer; we could perhaps use a 'shortcut report' to speed it up.

Displaying both sides of the toggle button happens because the app merges reports from ~15 seconds of history, during which time both buttons appear in reports from the probe. Given we have special merging code for this field, maybe we can have it recognize the toggle nature.