search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.83k stars 708 forks source link

probe: translate CRI container state #3899

Open bboreham opened 2 years ago

bboreham commented 2 years ago

Use values consistent with what we use for Docker. This avoids seeing all containers as 'stopped', as noted at #3880.

CVilinsky commented 2 years ago

Hi, can you elaborate on that? I changed the ds.yaml as you mentioned, and now I can see the containers but they are all 'stopped'.

bboreham commented 2 years ago

This is a proposed change to the Go code to fix the issue. Are you are able to download this branch and build your own container?

CVilinsky commented 2 years ago

Yes, I have cloned your branch, but still I still can't see any containers. I have also made the changes you've noted in #3880 , because my container-runtime is 'containerd'.

ghost commented 1 year ago

I can confirm that this fixes seeing all containers as 'stopped', but I wonder if it's useful for anything. When I click on a container the side widget only shows 'sha256 ... not found' and the pod and host the container is running in. 'by DNS name' and 'by image' is still empty.