search

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/oss/scope/
Apache License 2.0
5.83k stars 708 forks source link

Update Go to 1.17.8; tidy build image #3902

Closed bboreham closed 2 years ago

bboreham commented 2 years ago

Need to specify -buster otherwise libpcap gets unresolved symbols.

Add back a missing && after installing packages; it doesn't make a practical difference but looks more consistent to me.

Stop rebuilding various Go libraries since they are now cached automatically for each different set of tags, and in a different directory so the ones inside the image aren't actually used. Compare build on master vs this branch:

weaveworks/scope-backend-build      master-a774857b        af5063a2025a     1.54GB
weaveworks/scope-backend-build      go-1-17-8-87988e5a     0bec25faf9c5     1.15GB

I have uploaded a copy of the build image to DockerHub at bboreham/scope-backend-build:go-1-17-8-87988e5a since I don't have write access to weaveworks/scope-backend-build.

mnowster commented 2 years ago

Hi @bboreham is there something that needs updating to the weaveworks build? I don't think uploading something to your personal one seems like a good idea on a weave open project. Is there something I can help with here? do you want to email me and talk about it?

bboreham commented 2 years ago

Hi @mnowster,

The steps are: build Weave Scope (clone the repo and run make); this will create a Docker image tagged as weaveworks/scope-backend-build; push that image to DockerHub and this PR can be changed to use that tag.

Me pushing my own image serves to confirm it will go through CI cleanly once tagged appropriately.

mnowster commented 2 years ago

ah gotcha, thanks @bboreham 👍🏻 ok, let me sort out getting a new build pushed for you.

mnowster commented 2 years ago

Hi @bboreham, apologies for the delay turns out I didn't have permissions either! Fixed now.

We pushed a new image weaveworks/scope-backend-build:go-1-17-8-bcdf2caa

Let me know if I can do anything else to help! Hope you're well :)

bboreham commented 2 years ago

Add back a missing && after installing packages, so temp files aren't committed to the image.

For the record this didn't make the difference, it was all in the Go build, the next change in Dockerfile.

However I'm going to merge this as-is to avoid another round of pushing image updates.