weaveworks / service

☁️ Images for Weave Cloud (R) (TM) (C) ☁️
https://cloud.weave.works
2 stars 2 forks source link

Rate-limiter in email send should not report an internal error #2690

Closed bboreham closed 3 years ago

bboreham commented 4 years ago

If we get a lot of requests to signup, which generally means someone is trying to spam the service, they show up in metrics as a 500 code: image

Jaeger shows users reporting 500 and authfe reporting a 502, at almost exactly 60 seconds. I think this should be a 429.

Similar to #2688