weaveworks / service

☁️ Images for Weave Cloud (R) (TM) (C) ☁️
https://cloud.weave.works
2 stars 2 forks source link

scope-data-cleaning: Fix handling of empty lines #2735

Closed ozamosi closed 2 years ago

ozamosi commented 2 years ago

Copy-paste the empty/comment line handling code from a few lines up.

53b3482 claimed to add support for empty lines and comment lines. It did no such thing - it added support for counting empty lines and comment lines, but the job crashed whenever it tried to do anything with a file containing any of those things.

I still don't know if this actually works, but I know it no longer crashes when it starts to work on the current prod-records file, which starts with an empty line.