weaveworks / service

☁️ Images for Weave Cloud (R) (TM) (C) ☁️
https://cloud.weave.works
2 stars 2 forks source link

users: Add backwards compatibility for github logins #2747

Closed ozamosi closed 2 years ago

ozamosi commented 2 years ago

Since I moved to auth0, all the old accounts needs to re-associate, which they do automatically through the email address in the case after this. However, it seems a lot (a lot!) of github accounts aren't returning emails, thus the next fallback fails, and the user is denied access. In these cases, we could just, manually extract the plain github user ID and look for a user that way - if we find one, we can just let a new association be created, if not no harm done.