search

weaveworks / ui-components

A collection of UI components that are shared across Weaveworks projects
http://weaveworks-ui-components.s3-website-us-west-2.amazonaws.com/
Apache License 2.0
30 stars 26 forks source link

Introduce standard spacing to the theme #425

Closed fbarl closed 5 years ago

fbarl commented 5 years ago

Resolves #400.

bia commented 5 years ago

I'm surprised by how few changes there are here? Could you also remove constants.jsx? I think that's in the scope of this pr.

fbarl commented 5 years ago

I'm surprised by how few changes there are here?

This PR just creates the theme, #424 will apply it to all the components in the repo.

Could you also remove constants.jsx? I think that's in the scope of this pr.

That constant is still being used in service-ui repo, but good point - I'll remove it once https://github.com/weaveworks/service-ui/issues/3518 has been addressed :+1: