Difficult to see that dropdown can scroll sometimes.

weaveworks / ui-components

A collection of UI components that are shared across Weaveworks projects

http://weaveworks-ui-components.s3-website-us-west-2.amazonaws.com/

Apache License 2.0

30 stars 26 forks source link

Difficult to see that dropdown can scroll sometimes. #428

Closed foot closed 5 years ago

foot commented 5 years ago

I thought I'd lost some instances from the instances selector the other day before trying to scroll.

Easy fix would be to make the max-height a multiple of half an item height so that the last item is always chopped in half. A technique that https://react-select.com/home and others probably use.

bia commented 5 years ago

Hmmm - I don't like the idea of things getting chopped in half on purpose, but now that I've tried it on react-select it is compelling. Could mention it in my meeting with @miklosp tonight.

miklosp commented 5 years ago

Actually being chopped in half is a good way to show that there is more...