weaveworks / ui-components

A collection of UI components that are shared across Weaveworks projects
http://weaveworks-ui-components.s3-website-us-west-2.amazonaws.com/
Apache License 2.0
30 stars 26 forks source link

Bump D3 dependencies #449

Closed fbarl closed 5 years ago

fbarl commented 5 years ago

The TimeTravel panning issue appeared again because of older version of D3 being recorded in yarn.lock, so I thought it was a good time to bump those deps to get rid of the error.

fbarl commented 5 years ago

d3-select should be a peerdep maybe

That would solve the problem, but would put extra requirements for whoever wants to use our packages... I'd be really happy to learn about a better solution, or to be honest, rather ditch d3-selection than think about its versioning.

Perhaps https://github.com/mzabriskie/react-draggable or our own logic would work better :thinking: