weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 29 forks source link

[UI] User can not unselect the editable default profile. #1923

Closed saeedfazal closed 1 year ago

saeedfazal commented 1 year ago

WGE Story/Feature:

Priority

Severity

Describe the bug The "editable": true option for default profile doesn't work. Event after declaring the profile as editable, the rendered template shows the profile as selected and disabled.

To Reproduce

capi.weave.works/profile-1: '{"name": "cert-manager", "editable": true, "values": "installCRDs: ${INSTALL_CRDS}"}'

Actual behaviour The rendered template shows the default profile as selected by default but disabled. User can not unselect the profile

Expected behaviour The rendered template should show the default profile as selected and enabled. Used should be able to unselect the profile. The profile should not be the requirement to install.

Test Environment N/A

Additional context Screenshot 2022-11-21 at 14.16.27.png

foot commented 1 year ago
foot commented 1 year ago

Workaround: { "required": false }

foot commented 1 year ago

Lets make sure the user-guide around "required" vs "editable" is clear, e.g. mention explicitly that if you want to allow the user to deselect a profile then required must be set to false.