weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 29 forks source link

Insufficient Session Expiration - Low #2085

Open enekofb opened 1 year ago

enekofb commented 1 year ago

What Lack of proper session expiration

Why The lack of proper session expiration may improve the likely success of certain attacks. Although short session expiration times do not help if a stolen token is immediately used, they will protect against ongoing replaying of the session ID.

Recommendation Invalidate user JWT token after log-out, and after a fixed amount of time without receiving a valid request from the logged in user.

Acceptance Criteria

More info

enekofb commented 1 year ago

See comments from

@davidstauffer https://weaveworks.slack.com/archives/C03QNK53W68/p1669300686921979?thread_ts=1669298479.965169&cid=C03QNK53W68 and

@bigkevmcd in https://weaveworks.slack.com/archives/C03QNK53W68/p1669828001783499?thread_ts=1669298479.965169&cid=C03QNK53W68