weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 29 forks source link

Findings while verifying WGE v0.2.6 with flux v2.0.0 #3054

Closed enekofb closed 1 year ago

enekofb commented 1 year ago

This issue to gather the issues found with WGE after upgraded to v2.0.0 with @stefanprodan Using https://fluxga.eng-sandbox.weave.works

📓 this findings might have been already planned or addressed in (versions > v0.26)

stefanprodan commented 1 year ago

The apps which are failing to reconcile, broke the UI

Screenshot 2023-07-07 at 12 10 00

Also the "All workloads are passing health checks" doesn't look OK to me, there is no workload everything failed.

A link to the GA resource

When seen in the UI

This is the request like


curl 'https://fluxga.eng-sandbox.weave.works/v1/object/podinfo-ga?namespace=explorer-validation&kind=Kustomization&clusterName=management' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  --compressed

Response come as apiVersion\":\"kustomize.toolkit.fluxcd.io/v1beta2\",\

{"object":{"payload":"{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1beta2\",\"kind\":\"Kustomization\",\"metadata\":{\"creationTimestamp\":\"2023-06-09T09:18:23Z\",\"finalizers\":[\"finalizers.fluxcd.io\"],\"generation\":1,\"labels\":{\"kustomize.toolkit.fluxcd.io/name\":\"explorer-validation\",\"kustomize.toolkit.fluxcd.io/namespace\":\"flux-system\"},\"managedFields\":[{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:labels\":{\"f:kustomize.toolkit.fluxcd.io/name\":{},\"f:kustomize.toolkit.fluxcd.io/namespace\":{}}},\"f:spec\":{\"f:interval\":{},\"f:path\":{},\"f:prune\":{},\"f:sourceRef\":{\"f:kind\":{},\"f:name\":{}},\"f:timeout\":{}}},\"manager\":\"kustomize-controller\",\"operation\":\"Apply\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:finalizers\":{\".\":{},\"v:\\\"finalizers.fluxcd.io\\\"\":{}}}},\"manager\":\"gotk-kustomize-controller\",\"operation\":\"Update\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:status\":{\"f:conditions\":{},\"f:lastAttemptedRevision\":{}}},\"manager\":\"gotk-kustomize-controller\",\"operation\":\"Update\",\"subresource\":\"status\",\"time\":\"2023-06-09T09:18:25Z\"}],\"name\":\"podinfo-ga\",\"namespace\":\"explorer-validation\",\"resourceVersion\":\"19117328\",\"uid\":\"25f0441d-8083-4e55-897b-3a7fe7fe63bb\"},\"spec\":{\"force\":false,\"interval\":\"1m\",\"path\":\"./kustomize\",\"prune\":true,\"sourceRef\":{\"kind\":\"GitRepository\",\"name\":\"podinfo-ga\"},\"timeout\":\"1m\"},\"status\":{\"conditions\":[{\"lastTransitionTime\":\"2023-07-07T09:16:33Z\",\"message\":\"Detecting drift for revision master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa with a timeout of 1m0s\",\"observedGeneration\":1,\"reason\":\"ProgressingWithRetry\",\"status\":\"True\",\"type\":\"Reconciling\"},{\"lastTransitionTime\":\"2023-07-07T09:16:33Z\",\"message\":\"Service/podinfo namespace not specified: the server could not find the requested resource\\n\",\"observedGeneration\":1,\"reason\":\"ReconciliationFailed\",\"status\":\"False\",\"type\":\"Ready\"}],\"lastAttemptedRevision\":\"master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa\",\"observedGeneration\":-1}}\n", "clusterName":"management", "tenant":"", "uid":"25f0441d-8083-4e55-897b-3a7fe7fe63bb", "inventory":[], "info":"", "health":null}}
enekofb commented 1 year ago

Same as https://github.com/weaveworks/weave-gitops-enterprise/issues/3054#issuecomment-1625106118

But for gitrepositories https://github.com/weaveworks/clusters-config/blob/cluster-fluxga/eksctl-clusters/apps/validation/explorer/source-ga.yaml

UI shows the resources but comes as beta

https://fluxga.eng-sandbox.weave.works/git_repo/yaml?clusterName=management&name=podinfo-ga&namespace=explorer-validation

Screenshot 2023-07-07 at 10 29 35
{"object":{"payload":"{\"apiVersion\":\"source.toolkit.fluxcd.io/v1beta2\",\"kind\":\"GitRepository\",\"metadata\":{\"creationTimestamp\":\"2023-06-09T09:18:23Z\",\"finalizers\":[\"finalizers.fluxcd.io\"],\"generation\":1,\"labels\":{\"kustomize.toolkit.fluxcd.io/name\":\"explorer-validation\",\"kustomize.toolkit.fluxcd.io/namespace\":\"flux-system\"},\"managedFields\":[{\"apiVersion\":\"source.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:labels\":{\"f:kustomize.toolkit.fluxcd.io/name\":{},\"f:kustomize.toolkit.fluxcd.io/namespace\":{}}},\"f:spec\":{\"f:interval\":{},\"f:ref\":{\"f:branch\":{}},\"f:url\":{}}},\"manager\":\"kustomize-controller\",\"operation\":\"Apply\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"source.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:finalizers\":{\".\":{},\"v:\\\"finalizers.fluxcd.io\\\"\":{}}}},\"manager\":\"source-controller\",\"operation\":\"Update\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"source.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:status\":{\"f:artifact\":{\".\":{},\"f:digest\":{},\"f:lastUpdateTime\":{},\"f:path\":{},\"f:revision\":{},\"f:size\":{},\"f:url\":{}},\"f:conditions\":{},\"f:observedGeneration\":{}}},\"manager\":\"source-controller\",\"operation\":\"Update\",\"subresource\":\"status\",\"time\":\"2023-07-07T08:26:21Z\"}],\"name\":\"podinfo-ga\",\"namespace\":\"explorer-validation\",\"resourceVersion\":\"19093895\",\"uid\":\"0dd26324-100d-49e7-a01f-d7795ce5a54d\"},\"spec\":{\"interval\":\"10m\",\"ref\":{\"branch\":\"master\"},\"timeout\":\"60s\",\"url\":\"https://github.com/stefanprodan/podinfo\"},\"status\":{\"artifact\":{\"digest\":\"sha256:c894e5fad8e3a51ba4be72ada4beef3ee7be99f66770fd6f16488982bd226de8\",\"lastUpdateTime\":\"2023-07-07T08:26:21Z\",\"path\":\"gitrepository/explorer-validation/podinfo-ga/dd3869b1a177432b60ea1e3ba99c10fc9db850fa.tar.gz\",\"revision\":\"master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa\",\"size\":80066,\"url\":\"http://source-controller.flux-system.svc.cluster.local./gitrepository/explorer-validation/podinfo-ga/dd3869b1a177432b60ea1e3ba99c10fc9db850fa.tar.gz\"},\"conditions\":[{\"lastTransitionTime\":\"2023-07-07T08:26:21Z\",\"message\":\"stored artifact for revision 'master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa'\",\"observedGeneration\":1,\"reason\":\"Succeeded\",\"status\":\"True\",\"type\":\"Ready\"},{\"lastTransitionTime\":\"2023-07-07T08:26:21Z\",\"message\":\"stored artifact for revision 'master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa'\",\"observedGeneration\":1,\"reason\":\"Succeeded\",\"status\":\"True\",\"type\":\"ArtifactInStorage\"}],\"observedGeneration\":1}}\n", "clusterName":"management", "tenant":"", "uid":"0dd26324-100d-49e7-a01f-d7795ce5a54d", "inventory":[], "info":"", "health":null}}
enekofb commented 1 year ago

Kustomizations v1 yaml tab

https://github.com/weaveworks/weave-gitops-enterprise/issues/2939#issuecomment-1625170199

I believe that should be addressed by https://github.com/weaveworks/weave-gitops/issues/3626 And this PR https://github.com/weaveworks/weave-gitops/pull/3811

Update: Addressed in weave gitops v0.29

enekofb commented 1 year ago

The apps which are failing to reconcile, broke the UI Screenshot 2023-07-07 at 12 10 00

Also the "All workloads are passing health checks" doesn't look OK to me, there is no workload everything failed.

A link to the GA resource

When seen in the UI

This is the request like

curl 'https://fluxga.eng-sandbox.weave.works/v1/object/podinfo-ga?namespace=explorer-validation&kind=Kustomization&clusterName=management' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  --compressed

Response come as apiVersion\":\"kustomize.toolkit.fluxcd.io/v1beta2\",\

{"object":{"payload":"{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1beta2\",\"kind\":\"Kustomization\",\"metadata\":{\"creationTimestamp\":\"2023-06-09T09:18:23Z\",\"finalizers\":[\"finalizers.fluxcd.io\"],\"generation\":1,\"labels\":{\"kustomize.toolkit.fluxcd.io/name\":\"explorer-validation\",\"kustomize.toolkit.fluxcd.io/namespace\":\"flux-system\"},\"managedFields\":[{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:labels\":{\"f:kustomize.toolkit.fluxcd.io/name\":{},\"f:kustomize.toolkit.fluxcd.io/namespace\":{}}},\"f:spec\":{\"f:interval\":{},\"f:path\":{},\"f:prune\":{},\"f:sourceRef\":{\"f:kind\":{},\"f:name\":{}},\"f:timeout\":{}}},\"manager\":\"kustomize-controller\",\"operation\":\"Apply\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:finalizers\":{\".\":{},\"v:\\\"finalizers.fluxcd.io\\\"\":{}}}},\"manager\":\"gotk-kustomize-controller\",\"operation\":\"Update\",\"time\":\"2023-06-09T09:18:23Z\"},{\"apiVersion\":\"kustomize.toolkit.fluxcd.io/v1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:status\":{\"f:conditions\":{},\"f:lastAttemptedRevision\":{}}},\"manager\":\"gotk-kustomize-controller\",\"operation\":\"Update\",\"subresource\":\"status\",\"time\":\"2023-06-09T09:18:25Z\"}],\"name\":\"podinfo-ga\",\"namespace\":\"explorer-validation\",\"resourceVersion\":\"19117328\",\"uid\":\"25f0441d-8083-4e55-897b-3a7fe7fe63bb\"},\"spec\":{\"force\":false,\"interval\":\"1m\",\"path\":\"./kustomize\",\"prune\":true,\"sourceRef\":{\"kind\":\"GitRepository\",\"name\":\"podinfo-ga\"},\"timeout\":\"1m\"},\"status\":{\"conditions\":[{\"lastTransitionTime\":\"2023-07-07T09:16:33Z\",\"message\":\"Detecting drift for revision master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa with a timeout of 1m0s\",\"observedGeneration\":1,\"reason\":\"ProgressingWithRetry\",\"status\":\"True\",\"type\":\"Reconciling\"},{\"lastTransitionTime\":\"2023-07-07T09:16:33Z\",\"message\":\"Service/podinfo namespace not specified: the server could not find the requested resource\\n\",\"observedGeneration\":1,\"reason\":\"ReconciliationFailed\",\"status\":\"False\",\"type\":\"Ready\"}],\"lastAttemptedRevision\":\"master@sha1:dd3869b1a177432b60ea1e3ba99c10fc9db850fa\",\"observedGeneration\":-1}}\n", "clusterName":"management", "tenant":"", "uid":"25f0441d-8083-4e55-897b-3a7fe7fe63bb", "inventory":[], "info":"", "health":null}}

closing as the associated issue has been addressed

https://github.com/weaveworks/weave-gitops-enterprise/issues/3172#issuecomment-1688277965