search

weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 30 forks source link

Inconsistent behavior in Cluster Details page when having 2 clusters with the same name under different namespaces #3069

Closed taghreed86 closed 1 year ago

taghreed86 commented 1 year ago

Priority

Severity

Describe the bug I have 2 clusters with the same name under 2 different namespaces, and When I opened the Cluster details page for the second cluster , the system opened the details for the first cluster and after while auto-refreshed to display the details for the second cluster Then the page keeps refreshing and switching between the details for the 2 clusters.

To Reproduce

  1. Create new 2 namespaces using that commands kubectl create ns dev-namespace kubectl create ns test-namespace
  2. Create new leaf cluster under the namespace dev-namespace (I named it dev and I used the attached template if you don't have preferred one)
  3. After the first Cluster become ready , Create another leaf cluster under the namespace test-namespace and give it the same name dev
  4. When the second cluster become ready , open the Clusters List page.
  5. Press the Second Cluster Name to open its Details page.

Actual behaviour The system opened the details for the first cluster and after while auto-refreshed to display the details for the second cluster Then the page keeps refreshing and switching between the details for the 2 clusters.

Expected behaviour The system should Open the selected Cluster details page Only

Additional context I expect that the root cause of that issue that the system search for the cluster by name not by Id or unique value and that appears in the details page URL like the below https://demo-01.wge.dev.weave.works/cluster/details?clusterName=dev

https://images.zenhubusercontent.com/397340252/70d9814a-86b6-4306-895b-46564fd643d1/cluster_details_auto_refresh.mp4

foot commented 1 year ago

Related: https://github.com/weaveworks/weave-gitops-enterprise/issues/3027

foot commented 1 year ago

Current routes:

Other routes comes to mind? cc @AlinaGoaga @ahussein3

AlinaGoaga commented 1 year ago

There are a few more showing details I think like secrets and policy configs. Also add app which has got the cluster name but not the namespace.

I'll have a proper look into it and go through all the routes ;)

On Tue, Jul 11, 2023 at 12:23 PM Simon @.***> wrote:

Current routes:

- https://pesto-demo-01.eng-sandbox.weave.works/cluster/details?clusterName=pine-cone-not-to-be (is missing namespace)

https://pesto-demo-01.eng-sandbox.weave.works/templates/vcluster-template-development/create (could become /templates/create?name=&namespace=) ?

https://pesto-demo-01.eng-sandbox.weave.works/resources/edit?kind=GitopsCluster&name=pine-cone-not-to-be&namespace=default edit looks okay already

Other routes comes to mind? cc @AlinaGoaga https://github.com/AlinaGoaga @ahussein3 https://github.com/ahussein3

— Reply to this email directly, view it on GitHub https://github.com/weaveworks/weave-gitops-enterprise/issues/3069#issuecomment-1630565008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMSL7NVSXMVMIVASCE4UETXPUSQRANCNFSM6AAAAAA2FXLRK4 . You are receiving this because you were mentioned.Message ID: @.***>

taghreed86 commented 1 year ago

@AlinaGoaga @foot @ahussein3 kindly when I tried to re-test this issue I found that the cluster details page still keep refreshing and switch between the 2 clsuters views even after adding the namespace value in the page URL : https://test-cluster-details-issue.eng-sandbox.weave.works/cluster/details?clusterName=dev&namespace=test-namespace Note* username : wego-admin password : password kindly check the attached record for more details cc: @serboctor

https://images.zenhubusercontent.com/397340252/5ddf9d8b-eb76-4d55-8765-ed7e870a105f/cluster_details_after_fix.mp4

AlinaGoaga commented 1 year ago

Hi Taghreed, sorry about that, will have another look

AlinaGoaga commented 1 year ago

Should be fixed now @taghreed86, pls have a look when you have a min I tagged you in the PR