weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 30 forks source link

Extend explorer internal documentation with information on ToFluxObject #3281

Closed enekofb closed 1 year ago

enekofb commented 1 year ago

Pesto is extending Explorer with GitopsSets following the documentation and the internal guide

Where the following errors was found:

{"level":"error","ts":"2023-08-30T14:23:00.657Z","msg":"failed to get status from object management/default/gitopsset-configmaps","error":"unknown object type: *v1alpha1.GitOpsSet","stacktrace":"github.com/weaveworks/weave-gitops-enterprise/pkg/query/objectscollector.processRecords\n\t/Users/simon/weave/weave-gitops-enterprise/pkg/query/objectscollector/objectscollector.go:100[ngithub.com/weaveworks/weave-gitops-enterprise/pkg/query/objectscollector.NewObjectsCollector.func1](http://ngithub.com/weaveworks/weave-gitops-enterprise/pkg/query/objectscollector.NewObjectsCollector.func1)\n\t/Users/simon/weave/weave-gitops-enterprise/pkg/query/objectscollector/objectscollector.go:24"}

due to GitopsSet not be a FluxObject

This ticket to

AC

enekofb commented 1 year ago

Raised PR with extended documentation but feels that we should look into potentially break this depdency

https://github.com/weaveworks/weave-gitops-enterprise/blob/f36d549b6010afbd3c086c4955637586629ec589/pkg/query/internal/models/object.go#L113C1-L129

what do you think @jpellizzari ?

jpellizzari commented 1 year ago

PR approved :+1: