weaveworks / weave-gitops-enterprise

This repo provides the enterprise level features for the weave-gitops product, including CAPI cluster creation and team workspaces.
https://docs.gitops.weave.works/
Apache License 2.0
160 stars 29 forks source link

WGE Installation is dependent on CAPI #3658

Open bigkevmcd opened 11 months ago

bigkevmcd commented 11 months ago

Describe the bug https://github.com/weaveworks/weave-gitops-interlock/issues/605

We should require enabling all optional components, and document how and when to enable these.

For some, things like the template-controller and cluster-controller we should probably flip these to disable rather than enable and document under what circumstances you might want to disable these features (I can't think of any, but they are optional in the configuration).

To Reproduce

Actual behaviour

Expected behaviour

Additional context

foot commented 11 months ago
foot commented 11 months ago

https://github.com/helm/helm/issues/10296 describes the behaviour, which I've verified, that we don't need to actually clip the dependency.conditions, omitting the enabled: true is enough, it needs an explicit false to actually disable the subchart.

Don't exactly follow why. But we can follow this pattern..