search

weaveworks / weave-gitops

Weave GitOps provides insights into your application deployments, and makes continuous delivery with GitOps easier to adopt and scale across your teams.
https://docs.gitops.weave.works/
Apache License 2.0
905 stars 152 forks source link

Docs: Keycloak OIDC Guide #4113

Closed mircea-pavel-anton closed 10 months ago

mircea-pavel-anton commented 10 months ago

Addresses #4109

What changed?

Improved documentation to contain a step-by-step guide of configuring the Keycloak OIDC integration.

Why was this change made?

The documentation for the generic OIDC setup was not clear enough as to make the process seamless.

How did you validate the change?

By following the steps described in the guide 😆

Release notes

Documentation Changes

Not really, it's just docs.

mircea-pavel-anton commented 10 months ago

@bigkevmcd here is the PR for the Keycloak guide we talked about!

mircea-pavel-anton commented 10 months ago

I need to look a bit more into the file structure and the actual website config as I am not familiar with docusaurus at all 😅 But the content itself is pretty much done

mircea-pavel-anton commented 10 months ago

@makkes I will look on the comments this weekend and fix everything up! Thanks

makkes commented 10 months ago

@mirceanton can you please rebase your branch on top of main, get rid of the merge commits and squash the commits into a single one?

mircea-pavel-anton commented 10 months ago

@makkes done. Rebased and squashed. Though I must ask, why squash the commits on the MR instead of git merge --squash?

makkes commented 10 months ago

I replaced the Keycloak guide in the OIDC guide with a link to this new page and also moved this page to the top-level section for simplicity. Great job @mirceanton! /cc @bigkevmcd

makkes commented 10 months ago

Thanks a lot, @mirceanton. This will definitely save users from a lot of headaches. 👏🏻 🎖️