Add comment to suspend action

weaveworks / weave-gitops

Weave GitOps provides insights into your application deployments, and makes continuous delivery with GitOps easier to adopt and scale across your teams.

https://docs.gitops.weave.works/

Apache License 2.0

924 stars 153 forks source link

Add comment to suspend action #4147

Closed ahussein3 closed 11 months ago

ahussein3 commented 11 months ago

Partially Closes #3546

What changed?

Added new Modal component to let the User who is going to suspend resources to be able to add reason for suspenstion.

Why was this change made?

To add the ability to add a reason for suspension.

How did you validate the change?

Locally testing.

opudrovs commented 11 months ago

JS lint is failing.

opudrovs commented 11 months ago

There is a typo in the suspend modal title:

Screenshot 2023-11-27 at 16 31 06

opudrovs commented 11 months ago

❔ Probably expected behavior, just to make sure: is it OK that

a modal is displayed and a suspend comment is added to the toggle suspend request when suspending an object (for example, an automation) from the object's details pages (with the SyncActions component to which the new SuspendMessageModal component was added)
but not when suspending (possibly multiple) objects with the CheckboxActions component from the objects' list page?