Weave GitOps provides insights into your application deployments, and makes continuous delivery with GitOps easier to adopt and scale across your teams.
We state in our docs that we only support K8s releases that are supported upstream.
How was this change implemented?
This commit changes the behaviour of the gitops check command to create a client-go DiscoveryClient and use that to retrieve the server version. That way we don't have to rely on forking a kubectl process and the output being consistent.
The code is now much cleaner, easier to read and properly tested.
How did you validate the change?
Unit tests and manual runs.
Release notes
Fix gitops check command with most recent version of kubectl.
gitops check will only yield a positive result if the Kubernetes version is at least 1.26.0.
closes #4157
What changed?
gitops checkcommand works again.Why was this change made?
--shortflag has been removed fromkubectl versionin 1.28 (https://github.com/kubernetes/kubernetes/blob/7fe31be11fbe9b44af262d5f5cffb1e73648aa96/CHANGELOG/CHANGELOG-1.28.md#deprecation) so the command obviously fails now.How was this change implemented?
This commit changes the behaviour of the
gitops checkcommand to create a client-go DiscoveryClient and use that to retrieve the server version. That way we don't have to rely on forking akubectlprocess and the output being consistent.The code is now much cleaner, easier to read and properly tested.
How did you validate the change?
Unit tests and manual runs.
Release notes
gitops checkcommand with most recent version ofkubectl.gitops checkwill only yield a positive result if the Kubernetes version is at least 1.26.0.Documentation Changes
n/a