search

weaveworks / weave

Simple, resilient multi-host containers networking and more.
https://www.weave.works
Apache License 2.0
6.61k stars 665 forks source link

peer discovery through swarm #2400

Open rade opened 8 years ago

rade commented 8 years ago

It would be lovely if weave was able to discover peers through swarm, when it is operating on a swarm cluster, obviating the need to specify peer IPs on launch/connect. Especially now that swarm is built into Docker 1.12 via docker swarm ... and docker node ... commands.

bboreham commented 8 years ago

Believe this is basically the same as #1692

rade commented 8 years ago

Believe this is basically the same as #1692

Hmm. That refers to the global-mode plugin only. I was thinking that when running on swarm we could use that for discovery regardless of mode, even when using the proxy.

bboreham commented 8 years ago

That refers to the global-mode plugin only.

Which we install and run by default. However, I just tried it, and did not see the DiscoverNew call on docker swarm join. I am informed that plugins are not supported in "swarm mode".

Did you see an api for discovery in swarm mode? I guess we could poll, worst-case.

Some previous discussion at #1097.

pidster commented 8 years ago

Should this be a feature of libmesh?