search

weaveworks / weave

Simple, resilient multi-host containers networking and more.
https://www.weave.works
Apache License 2.0
6.62k stars 669 forks source link

cater for bleeding edge docker features in WEAVE[DNS]_DOCKER_ARGS #582

Open rade opened 9 years ago

rade commented 9 years ago

Following on from #388, and related to #576, the ability to apply special configuration to the weave and weavedns containers via WEAVE[DNS]_DOCKER_ARGS is limited by the docker version in the weavexec container, currently standing at 1.3.1.

At the very least we should document this limitation, though note that these vars themselves are only documented in the script at present.

Would also be good to find a way around that limitation.

rade commented 9 years ago

One idea I had is that weavexec could contain a complete set of dockers, with versions going back as far as we like. The script would then figure out which version to use based on what the server is running.

Obvious downsides are image size, weavexec build time, yet more scripting, and the need to add new versions relatively promptly following a docker release.

errordeveloper commented 9 years ago

Obvious downsides are image size

Supposedly this could be solved by using versioned image that would contain just the Docker client and we would only pull the one we need and mount it as a volume...

rade commented 8 years ago

see https://github.com/weaveworks/weave/issues/2234#issuecomment-215359266 for a suggestion that would allow users that really need it work around this.

bboreham commented 7 years ago

3110 makes this worse, since the command that runs weaveworks/weave is now weaveutil