search

weaveworks / wks-quickstart-firekube

Example configuration to create Kubernetes clusters powered by ignite and gitops
342 stars 372 forks source link

Dependencies aren't automatically upgraded when needed #54

Open dlespiau opened 5 years ago

dlespiau commented 5 years ago

When bumping the required version for one of our dependencies, such a footloose, setup.sh will just bail out instead of trying to upgrade (download) the new dependency.

$ ./setup.sh 
• Found jk 0.3.0
• Found footloose 0.6.1
• error: footloose: Found version 0.6.1 but 0.6.2 is the minimum required version.

firekube requires footloose to spawn VMs that will be used as Kubernetes nodes.

Please install footloose version 0.6.2 or later:

  • GitHub project  : https://github.com/weaveworks/footloose
  • Latest release  : https://github.com/weaveworks/footloose/releases
  • Installation    : https://github.com/weaveworks/footloose#install
  • Required version: 0.6.2

We should automatically remove the old version and download the new version!

stealthybox commented 5 years ago

This would be really cool, but some of these dependency upgrades may require user action. I'm not sure if there's a good way to go about that automatically without harming users.

stealthybox commented 5 years ago

What's even more confusing about this U/X is that we could be using the ignite binary from the user's PATH or from ~/.wks/bin/.

When we bump a dependency like we just did with #62, users aren't going to know to update their binary in one of two places, particularly since ~/.wks/bin/ is such an implementation detail.