weaveworks / wks-quickstart-firekube

Example configuration to create Kubernetes clusters powered by ignite and gitops
342 stars 370 forks source link

Changes for wksctl-0.8.2 #75

Closed kingdonb closed 4 years ago

kingdonb commented 4 years ago

Use SSH git repo refs by default, and WKSctl now expects cluster-key to be passed in as --git-deploy-key. So, the cluster-key is no longer referenced in cluster.yaml

These were all things I tripped over when I tried using the latest wksctl-0.8.2-alpha3. They should be backwards compatible (but I haven't tested.)

dholbach commented 4 years ago

With https://github.com/weaveworks/wksctl/releases/tag/v0.8.2 out, this PR might be more important again?

kingdonb commented 4 years ago

I've just tested with wksctl 0.8.4 that is in the master branch and everything works, but some weird thing happens with local Docker daemon (Docker for Mac) and the DNS server at 192.168.65.1 (my docker container subnet is 192.168.65.0/24 so this is a local DNS server in the Docker Daemon, I think, but it doesn't seem to work...)

weavek8sops   flux-56f57b4c7b-qr6dt             0/1     ImagePullBackOff   0          3m46s
weavek8sops   memcached-86ccc5bcbb-fg7qg        0/1     ImagePullBackOff   0          3m46s
weavek8sops   wks-controller-6b5b587cf7-8hx9g   0/1     ImagePullBackOff   0          3m46s

I was able to fix this by setting a DNS configuration in docker daemon.json like:

"dns": [ "8.8.8.8", "8.8.4.4" ],

Anyway I have a feeling this old PR from 0.8.2 era regarding cluster-key is not needed or relevant anymore, closing...