Fix for WKSctl v0.8.4 - Githubissues

weaveworks / wks-quickstart-firekube

Example configuration to create Kubernetes clusters powered by ignite and gitops

342 stars 370 forks source link

Closed chanwit closed 4 years ago

chanwit commented 4 years ago

This PR fixes Firekube to work with WKSctl v0.8.4

chanwit commented 4 years ago

There's still a problem with wksctl.yaml, in which we need to specify a correct version of controller

chanwit commented 4 years ago

@dholbach I pushed some updates to the start script. could you help reviewing a bit please?

dholbach commented 4 years ago

Did 12567678502656a71a36d6639947fabc38f553d2 end up as part of this branch by accident?

dholbach commented 4 years ago

The cluster comes up just fine - thanks a lot for your work on this.

chanwit commented 4 years ago

Did 1256767 end up as part of this branch by accident?

When we test against this branch, it'll push that kind of commit to the branch. I'll fix it for you. Don't worry @dholbach

chanwit commented 4 years ago

ping @dholbach ptal