weaviate / weaviate-benchmarking

Tools for various benchmarking scenarios
BSD 3-Clause "New" or "Revised" License
27 stars 13 forks source link

BUG: `weaviate.Client` is Deprecated and Should be Replaced with `weaviate.WeaviateClient` #22

Closed jspeed-meyers closed 4 months ago

jspeed-meyers commented 6 months ago

While troubleshooting on issue #19, I also ran into this issue:

DeprecationWarning: Dep016: Python client v3 `weaviate.Client(...)` connections and methods are deprecated. Update
            your code to use Python client v4 `weaviate.WeaviateClient` connections and methods.

            For Python Client v4 usage, see: https://weaviate.io/developers/weaviate/client-libraries/python
            For code migration, see: https://weaviate.io/developers/weaviate/client-libraries/python/v3_v4_migration

  warnings.warn(
<weaviate.client.Client object at 0x1022852b0>

This issue can be traced back to:

https://github.com/weaviate/weaviate-benchmarking/blob/5ed75e79cb91bdae78935941c2660305b1535b17/benchmark-scripts/src/functions.py#L252-L257

I'm starting to think that this benchmarking project has a number of outdated components. I wonder if this repo documentation should be changed to make it clear to user that this repo is not maintained, on the assumption it is intentionally not maintained?

ZJL0111 commented 3 months ago

hi, meyers, this issue may help you https://github.com/langchain-ai/langchain/pull/20443