Closed miniMaddy closed 2 years ago
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.
beep boop - the SeMI bot 👋🤖
Hi @madhavkumar1523, thanks for your contribution!
Could you add to your readme how the sentiment analysis is working? To make clear to people that the sentiment of an input sentence is not analyzed directly, but that it is compared to previously seen sentences and that the sentiment of the most similar sentence is returned? I'm asking this because the name might be misleading, SOTA sentiment analysis works differently than you perform here.
Hello @laura-ham, I have updated the readme. Please take a look at that and suggest any changes required.
Hi @madhavkumar1523, as discussed on Slack, please update the code so that the results will be good, or revoke the PR :) This way we ensure new users will see how to implement a good working sentiment analysis demo :) Thanks!
This is an example of sentiment analysis using twitter comments dataset on t2v-transformers module.