search

weaviate / weaviate-examples

Weaviate vector database – examples
MIT License
297 stars 72 forks source link

Added a example of toxicity classification using python and Tkinter library for GUI and also added a example demonstrating how to use weaviate in NodeJs and express server #7

Closed YASH-GU24 closed 2 years ago

weaviate-git-bot commented 2 years ago

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the SeMI bot 👋🤖

YASH-GU24 commented 2 years ago

I agree with CLA.

laura-ham commented 2 years ago

Hi @YASH-GU24

First of all, thanks for your contribution!

I've seen the code and readme, and I've one request before I will merge your PR. In your readme, you mention 'Make Sure docker file is running.'. However, I can't find a docker file in your folder. Can you add that please? In this dockerfile there is essential information which one needs to be able to run your example, such as which modules it uses.

YASH-GU24 commented 2 years ago

Hi @YASH-GU24

First of all, thanks for your contribution!

I've seen the code and readme, and I've one request before I will merge your PR. In your readme, you mention 'Make Sure docker file is running.'. However, I can't find a docker file in your folder. Can you add that please? In this dockerfile there is essential information which one needs to be able to run your example, such as which modules it uses.

Thanks for pointing that out!, Now I have added dockerfile for both examples.

laura-ham commented 2 years ago

Awesome! I'll merge it. Thanks @YASH-GU24 🎉

bobvanluijt commented 2 years ago

Hola @laura-ham - I notice that this one is already merged but you might want to reverse and remove the node_modules folder 👍

raam86 commented 2 years ago

Usually node modules are not not committed to git, I suggest removing them.