weaviate / weaviate-go-client

BSD 3-Clause "New" or "Revised" License
29 stars 11 forks source link

feat: use testcontainers-go module for weaviate #205

Closed mdelapenya closed 7 months ago

mdelapenya commented 7 months ago

Hi :wave: from testcontainers-go!

What does this PR do?

It uses the recently released weaviate module (please see https://golang.testcontainers.org/modules/weaviate/).

Why is it important?

Dogfooding the module will improve it for anybody else.

weaviate-git-bot commented 7 months ago

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

mdelapenya commented 7 months ago

I agree

antas-marcin commented 7 months ago

@mdelapenya Thank you for your contribution!! This is great! I have run the CI pipelines, once they are green I will merge your PR then.