weaviate / weaviate-helm

Helm charts to deploy Weaviate to k8s
https://weaviate.io/developers/weaviate/current/
BSD 3-Clause "New" or "Revised" License
47 stars 60 forks source link

If .env_AWS_* defined then env.ENABLE_MODULES is ignored #235

Open RogerSik opened 2 months ago

RogerSik commented 2 months ago

helm value:

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers'
            BACKUP_S3_BUCKET: 'CHANGE_ME'

argocd diff:

15_09-13-13

If:

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers'
            BACKUP_S3_BUCKET: 'CHANGE_ME'
            AWS_ACCESS_KEY_ID: 'CHANGE_ME'
            AWS_SECRET_ACCESS_KEY: 'CHANGE_ME'
            AWS_REGION: 'CHANGE_ME'

then

15_09-13-56

Both ENABLE_MODULES value i can confirm with

echo $ENABLE_MODULES 

in the container after deployment. ENABLEMODULES gets always ignored if one of AWS values are defined.

RogerSik commented 2 months ago

Found the reason.

If one of

is set than env.ENABLE_MODULES is ignored and will be by helm generated. It looks and see

          modules:
            text2vec-transformers:
              enabled: true

            qna-transformers:
              enabled: false

          env:
            ENABLE_MODULES: 'backup-s3,text2vec-transformers,qna-transformers' # <-- this gets ignored

and ignores the ENABLE_MODULES. We have qna-transformers outside of helm deployed because we coulnd't add

spec:
  template:
    spec:
      runtimeClassName: nvidia

to qna-transformers in the helm chart.