weaviate / weaviate-helm

Helm charts to deploy Weaviate to k8s
https://weaviate.io/developers/weaviate/current/
BSD 3-Clause "New" or "Revised" License
50 stars 64 forks source link

Adapt to Weaviate standalone #28

Closed etiennedi closed 3 years ago

etiennedi commented 4 years ago

Required Changes

fefi42 commented 3 years ago

The change successfully removed esvector and adds a statefulset for the weaviate pods. Etcd is still used by the contextionary and thus still kept around.

@etiennedi

  1. So far the pvc for the weaviate statefulSet is ReadWriteOnce. However I assume this must be ReadWriteMany once the chart should be horizontally scaleable. As far as I know gke is not supporting ReadWriteMany out of the box so we probably still need to keep the indirect dependency to the NFS provisioner or a similar thing.
  2. There was a mention to change all configuration to environment variables instead of the weaviate config map? Is that actually desired? If so is everything over env variables settable? So far authentication and authorization is set over the config, they might become a bit cumbersome in a env variable.
etiennedi commented 3 years ago

Thanks!

  1. ReadWriteOnce is fine. When it becomes horizontally scalable in the future, each node/pod will have its own independent disk and Weaviate will - at a software level - take care of replication, etc. Similar to ES or Cassandra. So there won't be multiple pods trying to ever read or write from the same disk.

  2. Good point, I'll check and get back to you.