search

web-aid-kit / ngx-image-gallery

Probably the best Angular 4+ modal and inline image gallery. Angular upgrade for ng-image-gallery.
79 stars 47 forks source link

documentation not up to date #28

Open Serrulien opened 5 years ago

Serrulien commented 5 years ago

prev and next don't take arguments.

in component (as you can see no args) : https://github.com/thatisuday/ngx-image-gallery/blob/c8403fca3084a9127d5e634c0c17131744c5787e/src/components/ngx-image-gallery/ngx-image-gallery.component.ts#L315-L327

But in the documentation : https://github.com/thatisuday/ngx-image-gallery/blob/c8403fca3084a9127d5e634c0c17131744c5787e/README.md#L131-L139

jaasmaz commented 5 years ago

I'm having the same problem did you fix it?

Serrulien commented 5 years ago

@jaasmaz I don't understand your problem. The gallery remains fully functional even if the documentation contains some errors. You should get a type error when giving an argument to next or prev methods as the .d.ts file is up to date. Thus just don't do that.