web-animations / web-animations-js

JavaScript implementation of the Web Animations API
http://web-animations.github.io
Apache License 2.0
3.77k stars 408 forks source link

updatePlaybackRate #218

Open amk221 opened 4 years ago

amk221 commented 4 years ago

I use animation.playbackRate = -1 to reverse an animation mid-way through.

This has recently stopped working in Chrome, but it does work if I change it to animation.updatePlaybackRate(-1)

However, that isn't polyfilled, so I have to write code like:

if (animation.updatePlaybackRate) {
  animation.updatePlaybackRate(playbackRate);
} else {
  animation.playbackRate = playbackRate;
}
birtles commented 4 years ago

I use animation.playbackRate = -1 to reverse an animation mid-way through.

This has recently stopped working in Chrome

Do you have a test case where this doesn't work in Chrome? I'm pretty sure it's a bug they'd like to know about it.

That said, updatePlaybackRate is preferred over setting the playbackRate since it will make sure the change happens smoothly for animations running on a separate thread/process.

amk221 commented 4 years ago

👌I haven't raised an issue yet: https://jsfiddle.net/amk221/2n60su37/

birtles commented 4 years ago

I can reproduce the bug in Canary but not release. Do you need help filing the bug?

amk221 commented 4 years ago

Sure, I’ve not raised one against Chrome before, ty

On Fri, 14 Feb 2020 at 01:43, Brian Birtles notifications@github.com wrote:

I can reproduce the bug in Canary but not release. Do you need help filing the bug?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/web-animations/web-animations-js/issues/218?email_source=notifications&email_token=AAC5I3IQDU32V3UFUV4MZBDRCXZLZA5CNFSM4KUVT5VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXILXA#issuecomment-586057180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5I3MRRO36MSFJDIUNCB3RCXZLZANCNFSM4KUVT5VA .

birtles commented 4 years ago

No problem, I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1052217 for this. /cc @kevers-google @stephenmcgruer