search

web-animations / web-animations-next

Development repository for web-animations-js:
https://github.com/web-animations/web-animations-js
Apache License 2.0
121 stars 30 forks source link

Non-px lengths in matrix decompositions aren't handled #177

Open rjwright opened 9 years ago

rjwright commented 9 years ago

The following keyframes raise an uncaught TypeError.

[{transform: 'translate(50em)'},
{transform: 'translate(200px) rotate(40deg)'}]

This is fine:

[{transform: 'translate(50px)'},
{transform: 'translate(200px) rotate(40deg)'}]

As is this:

[{transform: 'translate(50em)'},
{transform: 'translate(200px)'}]

Will fix the TypeError ASAP, and replace it with treating non-px lengths as 0px (this it not a total fix, just a better failure).

rjwright commented 9 years ago

https://github.com/web-animations/web-animations-next/pull/178 stops the error and ignores non-px lengths instead