web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework
MIT License
421 stars 54 forks source link

Fix wrong key name in PublicKeyCredentialCreationOptionsFactory.php, rename authenticator_attachment to attachment_mode #469

Closed nicodemuz closed 1 year ago

nicodemuz commented 1 year ago

Target branch: 4.7

No idea if this is the correct way to fix this, but when I was upgrading to the latest 4.7 version, I was encountering this issue:

{"status":"error","errorMessage":"Warning: Undefined array key \u0022authenticator_attachment\u0022"}
Spomky commented 1 year ago

This should de fixed by #467

nicodemuz commented 1 year ago

Ah sorry, I didn't see that. I just upgraded to 4.7.x-dev and it seems to work. Thanks!