Lower infection's min value

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework

MIT License

403 stars 53 forks source link

Lower infection's min value #493

Closed szepeviktor closed 1 month ago

szepeviktor commented 11 months ago

No one writes tests 😢

[ ] It is a Bug fix
[ ] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

szepeviktor commented 11 months ago

The minimum required MSI percentage should be 42%, but actual is
41.28%. Improve your tests!

Spomky commented 11 months ago

Many thanks for trying to fix the tests. Actually, the last versions are full of deprecated features that make this minimum value less relevant. The version 4.8 will be the last 4.x version and 5. 0 will get rid of all deprecations. To sum up: do not try to fix it, it will be more relevant in next major release.

Spomky commented 1 month ago

Closing as fixed since the release of 5.0.0. Because all deprecated portions of code are gone, this test is now green.