feat: add packages required for serialization

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework

MIT License

397 stars 51 forks source link

feat: add packages required for serialization #560

Closed joostdebruijn closed 5 months ago

joostdebruijn commented 5 months ago

Target branch: 4.8.0 Resolves issue: n/a

[ ] It is a Bug fix
[x] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

Those packages are required to make the serializer work.

Spomky commented 5 months ago

Hi,

😅 I missed these dependencies. They are also needed in MetadataStatementSerializerFactory.

joostdebruijn commented 5 months ago

@Spomky Thanks for merging this one! However, the web-auth/webauthn-lib sub repository doesn't have the Symfony serializer related packages now (also not in the suggest)? I'm using that sub repo for my own implementation in the Laravel-framework, however the three Symfony serializer related packages are necessary for parsing the authenticator responses for example. Shouldn't they be added as suggested package at least?

Spomky commented 5 months ago

No worries, it is automatically split and tagged on release

joostdebruijn commented 5 months ago

@Spomky Hm, I'm using v4.8.1 now and when only requiring web-auth/webauthn-lib, the symfony serializer packages must be installed separately.

joostdebruijn commented 5 months ago

The package phpdocumentor/reflection-docblock should be added as dependency well as I discovered in production where my dev dependencies are not installed. 😅