fix: Support 4.7.x publickey data in PublicKeyCredentialSource::createFromArray

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework

MIT License

397 stars 51 forks source link

fix: Support 4.7.x publickey data in PublicKeyCredentialSource::createFromArray #564

Closed bnf closed 5 months ago

bnf commented 5 months ago

Target branch: 4.8.x Resolves issue #563

[x] It is a Bug fix
[ ] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

With #513 backupEligible, backupStatus and uvInitialized became mandatatory public key attributes, while webauthn-lib versions prior to 4.8.0 did not generated this public key attributes, which means a public key generated with 4.7.x must not be reported as invalid.

Spomky commented 5 months ago

My bad. I missed those 2 properties. Many thanks!

bnf commented 5 months ago

No problem, things like that can happen… Thanks!

Seems use function in_array; was missing; will you fix directly or should I fill a followup PR?