search

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework
MIT License
410 stars 54 forks source link

Incorrect deprecations #572

Closed bobvandevijver closed 6 months ago

bobvandevijver commented 7 months ago

Version(s) affected

4.8.0

Description

The PublicKeyCredentialLoader has two kinds of deprecations: one which states that the complete class will disappear, and one that implies that the class will still be available (both deprecations started in 4.8, and target 5.0).

How to reproduce

Check the deprecations in https://github.com/web-auth/webauthn-framework/blob/4.8.x/src/webauthn/src/PublicKeyCredentialLoader.php.

Possible Solution

Either fully deprecate the class (and update the docs accordingly, see also #570) and update the deprecation messages (even remove the once that mention changed behaviour for 5.0), or undeprecate the class.

Additional Context

No response

Spomky commented 6 months ago

Hello @bobvandevijver,

Indeed, the class is now deprecated but the other deprecation notices are very confusing. This will be fixed.

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.