Refactor authenticator response identification logic

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework

MIT License

381 stars 51 forks source link

Refactor authenticator response identification logic #587

Closed Spomky closed 3 months ago

Spomky commented 3 months ago

The logic for identifying the type of Authenticator Response has been simplified. Instead of checking for multiple array keys in a data object, we now simply check for the presence of either 'attestationObject' or 'signature'. This refactoring leads to cleaner and more maintainable code.

Target branch: 4.8.x Resolves issue #583

[x] It is a Bug fix
[ ] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud