getAlternativeDescriptions can return null

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework

MIT License

381 stars 51 forks source link

getAlternativeDescriptions can return null #595

Closed marcriemer closed 1 month ago

marcriemer commented 1 month ago

Target branch: 5.0.x

The alternativeDescriptions property is optional in the constructor, and alternative descriptions are often not present in the fido metadata. This causes issues during deserialization. Therefore, the return of getAlternativeDescriptions() must be optional.

[X] It is a Bug fix
[ ] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

Spomky commented 1 month ago

Many thanks. As this method will be removed in branch 5.0.x, I suggest rebasing on 4.8.x.

Spomky commented 1 month ago

Resolved with #599. The version 4.8.7 tag will be applied shortly.