search

web-auth / webauthn-framework

FIDO-U2F / FIDO2 / Webauthn Framework
MIT License
403 stars 53 forks source link

Missing dependency - phpdocumentor/reflection-docblock #629

Closed arokettu closed 1 month ago

arokettu commented 2 months ago

Version(s) affected

4.8.6, 4.9.0

Description

Using raw webauth-lib generates these errors:

LogicException Unable to use the "Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor" class as the "phpdocumentor/reflection-docblock" package is not installed. Try running composer require "phpdocumentor/reflection-docblock".

How to reproduce

<?php

use Webauthn\AttestationStatement\AttestationStatementSupportManager;
use Webauthn\Denormalizer\WebauthnSerializerFactory;

(new WebauthnSerializerFactory(new AttestationStatementSupportManager()))->create();

Possible Solution

Move phpdocumentor/reflection-docblock requirement from web-auth/webauthn-symfony-bundle to web-auth/webauthn-lib

Additional Context

No response

Spomky commented 2 months ago

Hi @arokettu,

This dependency is not mandatory for the 4.x branchs. Either you use the builtin createFrom... methods or you use the serializer introduced in 4.8.0. With the latter, it is required to installed extra dependencies.

github-actions[bot] commented 3 weeks ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.