search

web-cat / pythy

Pythy – the Cloud-Based IDE for Novice Python Programmers
18 stars 3 forks source link

Move course "settings" from button to tab #24

Closed s-edwards closed 11 years ago

s-edwards commented 11 years ago

For instructors, when viewing the main page for a course, there are three tabs (assignments, users, and grades). In addition, there is a "settings" icon in the title area next to the "viewing" dropdown list that shows available courses. The "settings" icon goes to the "view" page for the course offering, which also shows the users ... and access to the "edit" link to edit the course offering.

It would probably be better to unify these two, and provide edit access for the course offering properties on one more tab on the main page for the course, getting rid of the "settings" icon.

allevato commented 11 years ago

Agreed, this was one of my longer term plans that never got realized. The original settings page is a remnant of the old RESTful scaffolding pages that we started with. Once I redesigned the course home page to be a lot more feature-filled, there were still some sections that hadn't been ported over yet.

Moving the settings page over and deleting all of the old course scaffolding pages is the right thing to do here. Lower level tweaking can be done with the turnkey RailsAdmin interface if needed (like Web-CAT's D2W admin pages).

ArturAguiar commented 11 years ago

I have done just that as seen below: pythy course settings This also works when viewing a specific course offering and the form in the settings tab changes accordingly.

The only thing that might still be lacking is that when the form gets submitted, it sends the user to the course page with the user/staff listing. Should I change this?

s-edwards commented 11 years ago

Nice job. Yes, when the form gets submitted, it should send the user back to this page, on the same tab, with a flash notification confirming success of the save.